Skip to content

ext/ldap: few new unit tests (tls13 protocol). #13409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

devnexen
Copy link
Member

No description provided.

@nielsdos
Copy link
Member

I think a better idea is to split each of these tests into two files based on whether the constant is defined. Because now we're skipping on older versions, although that may be no a big deal. Wdyt?

@devnexen
Copy link
Member Author

alright, gonna split it.

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some redundancy now between the tests, an option could be to add version checks to the files such that only one variant of the two is executed.
But I think this is good enough.

@devnexen devnexen merged commit 0941507 into php:master Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants