-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Implement "support doc comments for internal classes and functions" #13266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0cd6b0c
to
f3546b6
Compare
f3546b6
to
7f00352
Compare
@iluuu1994 I slightly refactored the behavior, and now When implementing this, I added support for conditional frameless func info item generation based on the PHP version compatibility requirements. I didn't commit this fix separately because it needed the PHP version compatibility info which I had just added in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and ack for ext/random.
pgsql looks ok to me. |
f8a8262
to
627d8e9
Compare
Ilija, could you have another look please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The C code LGTM! I didn't look closely at build/gen_stub.php
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also didn't check gen_stub too closely
Fixes #13130
The biggest change of this PR (besides the internal structures of functions and classes) is how function entries are generated by gen_stub.php: so far the higher level macros were used (
ZEND_ME
,ZEND_FALIAS
etc.), but since the variations we have has already started to skyrocket, I decided to go with theZEND_RAW_FENTRY
macro which is the lowest level... As we now have a decent framework for generating the arginfo.h file by taking into account older PHP versions as well, I think this change is less problematic... A random example:(
NULL
stands for thedoc_comment
in the function entry generated for PHP 8.4+).