Anonymous classes (2) #1249
Closed
Anonymous classes (2) #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop dead "parent" code
| { | ||
| // TODO The opline pointer may be reused, this is not safe! | ||
| uint32_t next = get_next_op_number(CG(active_op_array)); | ||
| return zend_strpprintf(0, "class@%p", &CG(active_op_array)->opcodes[next-1]); |
There was a problem hiding this comment.
I think it is better if it uses a unique id (self-incresemenet)....will be good for debuting..
Closed
|
Superseded by #1250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open problem: Generating a name for the anon class.