Skip to content

Fix #12063 convert PHP single-quote to C double-quote string #12064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix #12063 convert PHP single-quote to C double-quote string #12064

wants to merge 1 commit into from

Conversation

remicollet
Copy link
Member

@remicollet remicollet commented Aug 28, 2023 •
edited
Loading

See #12063

Ensure we generate C code with properly double-quote strings

@remicollet remicollet requested a review from kocsismate as a code owner August 28, 2023 09:50
@remicollet remicollet mentioned this pull request Aug 28, 2023
Closed
TimWolla
TimWolla reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be fixed in getCExpr which also converts null to NULL?

@remicollet
Copy link
Member Author

Should this be fixed in getCExpr which also converts null to NULL?

Indeed, moved

@remicollet remicollet changed the title Fix 12063 convert PHP single-quote to C double-quote strings Fix #12063 convert PHP single-quote to C double-quote string Aug 28, 2023
@remicollet remicollet requested a review from TimWolla August 28, 2023 11:52
TimWolla
TimWolla approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert, but this appears to be reasonable.

kocsismate
kocsismate approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Very nice catch! :)

@remicollet
Copy link
Member Author

Thanks the the reviews

Merged as 13d3564

@remicollet remicollet closed this Aug 28, 2023
@remicollet remicollet deleted the issue-12063 branch August 28, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla approved these changes

@kocsismate kocsismate kocsismate approved these changes

Assignees
No one assigned
Labels
Category: Build System Extension: zend_test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remicollet @TimWolla @kocsismate