Allow FETCH_OBJ_W and FETCH_STATIC_PROP_W to return INDIRECT/UNDEF zval for uninitialized typed properties #11048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al for uninitialized typed properties
nikic
reviewed
Apr 10, 2023
| @@ -1037,6 +1037,8 @@ ZEND_API zval *zend_std_get_property_ptr_ptr(zend_object *zobj, zend_string *nam | |||
| } else if (prop_info && UNEXPECTED(prop_info->flags & ZEND_ACC_READONLY)) { | |||
| /* Readonly property, delegate to read_property + write_property. */ | |||
| retval = NULL; | |||
| } else if (!prop_info || !ZEND_TYPE_IS_SET(prop_info->type)) { | |||
| ZVAL_NULL(retval); | |||
There was a problem hiding this comment.
This ZVAL_NULL() was moved into zend_fetch_property_address() by typed-properties patch.
Without it uninitialized not-typed properties are not converted to NULL.
Zend/tests/type_declarations/typed_properties_098.phpt was broken.
nikic
approved these changes
Apr 10, 2023
dstogov
added a commit
that referenced
this pull request
Apr 10, 2023
* PHP-8.1: Allow FETCH_OBJ_W and FETCH_STATIC_PROP_W to return INDIRECT/UNDEF zval for uninitialized typed properties (#11048)
dstogov
added a commit
that referenced
this pull request
Apr 10, 2023
* PHP-8.2: Allow FETCH_OBJ_W and FETCH_STATIC_PROP_W to return INDIRECT/UNDEF zval for uninitialized typed properties (#11048)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an opposite approach to #11046