Skip to content

Add case insensitive versions of the zend_string_starts_with_* APIs #11032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2023
Merged

Add case insensitive versions of the zend_string_starts_with_* APIs #11032

merged 1 commit into from
Apr 10, 2023

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Apr 7, 2023

We have the case-sensitive ones, having the case-insensitive ones makes sense.

Found while staring at ext/phar and realizing that stream wrapper protocols are case-insensitive.

@Girgias Girgias requested a review from dstogov as a code owner April 7, 2023 13:58
@Girgias Girgias mentioned this pull request Apr 7, 2023
Closed
dstogov
dstogov approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems

@Girgias Girgias merged commit b9af980 into php:master Apr 10, 2023
@Girgias Girgias deleted the zend_string-starts-with-ci-helper branch April 10, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov dstogov approved these changes

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @dstogov