Skip to content

Improve ini number handling with INI_SCANNER_TYPED #11014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improve ini number handling with INI_SCANNER_TYPED #11014

wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

Fixes GH-11010

@iluuu1994 iluuu1994 marked this pull request as ready for review April 4, 2023 16:31
@iluuu1994 iluuu1994 requested a review from Girgias April 4, 2023 16:31
@Girgias Girgias requested a review from arnaud-lb April 5, 2023 11:37
Girgias
Girgias approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible, but Arnaud is the one who touched the INI parsing code most recently, so would like for him to have a quick glance at this too. :)

arnaud-lb
arnaud-lb approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@iluuu1994 iluuu1994 closed this in 86ffde3 Apr 11, 2023
iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request Apr 17, 2023
@iluuu1994
Fix uninitialized memory in parse_ini_string()
ce6d342 
Introduced by phpGH-11014
@iluuu1994 iluuu1994 mentioned this pull request Apr 17, 2023
Closed
iluuu1994 added a commit that referenced this pull request Apr 17, 2023
@iluuu1994
Fix uninitialized memory in parse_ini_string()
b340e10 
Introduced by GH-11014

Fixes oss-fuzz #58080
Closes GH-11092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Category: Engine Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parse_ini_file parse_ini_string bug when when INI_SCANNER_TYPED
3 participants
@iluuu1994 @arnaud-lb @Girgias