-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Remove name field from the zend_constant struct #10954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As global constant names are case-sensitive now, we don't have to store them separately above the constant table.
64a8c83
to
a53db09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this looks good.
There are problems with inaccurate reference-counting and few (probably related) tests failures.
I'll make another quick review when the tests are fixed. Please ping me.
ad4f740
to
29e5ead
Compare
3a4ce5d
to
0c64e89
Compare
Finally, tests all pass :) So can I have a review round again? (I'll handle the UPGRADING.INTERNALS entry later) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any problems. Only one cosmetic suggestion.
This reverts commit f42992f.
This reverts commit f42992f.
This reverts commit f42992f. Closes phpGH-11604
As global constant names are case-sensitive now, we don't have to store them separately above the constant table keys.