Skip to content

Remove name field from the zend_constant struct #10954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2023

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Mar 27, 2023

As global constant names are case-sensitive now, we don't have to store them separately above the constant table keys.

As global constant names are case-sensitive now, we don't have to store them separately above the constant table.
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this looks good.
There are problems with inaccurate reference-counting and few (probably related) tests failures.
I'll make another quick review when the tests are fixed. Please ping me.

@kocsismate
Copy link
Member Author

Finally, tests all pass :) So can I have a review round again? (I'll handle the UPGRADING.INTERNALS entry later)

Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems. Only one cosmetic suggestion.

@kocsismate kocsismate merged commit f42992f into php:master Apr 3, 2023
@kocsismate kocsismate deleted the remove-const-name branch April 3, 2023 20:13
kocsismate added a commit that referenced this pull request Jul 3, 2023
iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request Jul 4, 2023
iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request Jul 4, 2023
iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request Jul 6, 2023
iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request Jul 17, 2023
iluuu1994 added a commit to iluuu1994/php-src that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants