Fix GH-10489: run-tests.php does not escape path when building cmd #10560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Feb 10, 2023
mvorisek
reviewed
Feb 10, 2023
mvorisek
reviewed
Feb 10, 2023
mvorisek
reviewed
Feb 10, 2023
7a0635a to
8cd9090
Compare
Girgias
reviewed
Feb 13, 2023
d77cb70 to
cbc10c6
Compare
|
I applied @Girgias 's feedback and everything's green :). |
mvorisek
reviewed
Feb 14, 2023
c25e501 to
8dae878
Compare
Girgias
approved these changes
Feb 18, 2023
mvorisek
reviewed
Feb 18, 2023
|
Can you please rebase this onto master, as trying to merge this upwards is a massive hassle and I don't think it's really worth it to fix in release versions... |
|
Finally rebased this on master. |
|
Windows seems to be failing for reasons |
|
Is it possible to retrigger Windows alone, or should I just rerun all of CI by doing rebase+force push? |
I don't think I can retrigger appveyor sadly :/ |
Multiple tests had to be changed to escape the arguments in shell commands. Some tests are skipped because they behave differently with spaces in the path versus without. One notable example of this is the hashbang test which does not work because spaces in hashbangs paths are not supported in Linux.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-10489
Multiple tests had to be changed to escape the arguments in shell
commands. Some tests are skipped because they behave differently with
spaces in the path versus without. One notable example of this is the
hashbang test which does not work because spaces in hashbangs paths are
not supported in Linux.