Skip to content

include cleanup part 5 #10345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 105 commits into from
Closed

include cleanup part 5 #10345

wants to merge 105 commits into from

Conversation

MaxKellermann
Copy link
Contributor

@MaxKellermann MaxKellermann commented Jan 16, 2023 •
edited
Loading

This is a "revert of revert" of my include cleanup PRs: #10216 #10220 #10279 #10300 ... plus a few more commits (including the DTrace fix #10334)

My previous work was reverted after @dstogov demanded it: #10220 (comment)

Meanwhile, I have posted a suggestion to update PHP's coding standard in favor of my cleanups:

Until it is decided whether to accept my coding standard suggestion, I'll keep this PR up to date for you to review.

@MaxKellermann
ext/opcache/zend_accelerator_blacklist: include cleanup
a639562
@MaxKellermann
ext/opcache/zend_shared_alloc: include cleanup
9cc1c9c
@MaxKellermann
ext/opcache/jit: include cleanup
c54fa44
@MaxKellermann
main/php_ini: include cleanup
d2fdbc4
@MaxKellermann
ext/opcache/zend_accelerator_module: include cleanup
bd9cd9f
@MaxKellermann
ext/opcache/ZendAccelerator: include cleanup
f9a22a9
@MaxKellermann
ext/opcache/zend_persist: include cleanup
ebb2179
@MaxKellermann
Zend/zend_virtual_cwd: include cleanup
4e47f42
@MaxKellermann
Zend/zend_strtod: include cleanup
38f1ba6
@MaxKellermann
Zend/zend_stack: include cleanup
bac2006
@MaxKellermann
Zend/zend_highlight: include cleanup
c88819b
@MaxKellermann
Zend/zend_gdb: include cleanup
dadc012
@MaxKellermann
Zend/zend_modules: include cleanup
c2d203e
@MaxKellermann
Zend/zend_cpuinfo: include cleanup
2801fd6
@MaxKellermann
Zend/zend_attributes: include cleanup
f6fc88c
@MaxKellermann
ext/opcache/jit/zend_jit_gdb: include cleanup
0e80019
@MaxKellermann
sapi/phpdbg: include cleanup
1d57321
@MaxKellermann
Zend/zend: include cleanup
2e7daa2
@MaxKellermann
ext/opcache/zend_accelerator_util_funcs: include cleanup
7613004
@MaxKellermann
Zend/zend_builtin_functions: include cleanup
98b47e8
@MaxKellermann
Zend/zend_opcode: include cleanup
9bcbf5a
@MaxKellermann
Zend/zend_portability: move unnecessary includes to main/php.h
d8a21e7
@MaxKellermann
Zend/zend_inheritance: include cleanup
1250ca5
@MaxKellermann
Zend/zend.h: move zend_error*() prototypes to zend_error.h
33b360b
@MaxKellermann
Zend/Optimizer/zend_func_info: include cleanup
5d0d5b6
@MaxKellermann
Zend/zend_default_classes: include cleanup
70a8cb4
@MaxKellermann
Zend/zend_cpuinfo.h: use inline instead of zend_always_inline
7b56e39 
This eliminates the need to include zend_portability.h.
@MaxKellermann MaxKellermann deleted the include_cleanup5 branch March 6, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smalyshev smalyshev smalyshev left review comments

@nbish11 nbish11 nbish11 left review comments

@devnexen devnexen devnexen left review comments

@dstogov dstogov dstogov requested changes

@arnaud-lb arnaud-lb Awaiting requested review from arnaud-lb arnaud-lb will be requested when the pull request is marked ready for review arnaud-lb is a code owner

@bukka bukka Awaiting requested review from bukka bukka will be requested when the pull request is marked ready for review bukka is a code owner

@Girgias Girgias Awaiting requested review from Girgias Girgias will be requested when the pull request is marked ready for review Girgias is a code owner

@nielsdos nielsdos Awaiting requested review from nielsdos nielsdos will be requested when the pull request is marked ready for review nielsdos is a code owner

@TimWolla TimWolla Awaiting requested review from TimWolla TimWolla will be requested when the pull request is marked ready for review TimWolla is a code owner

@zeriyoshi zeriyoshi Awaiting requested review from zeriyoshi zeriyoshi will be requested when the pull request is marked ready for review zeriyoshi is a code owner

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi will be requested when the pull request is marked ready for review SakiTakamachi is a code owner

@kamil-tekiela kamil-tekiela Awaiting requested review from kamil-tekiela kamil-tekiela will be requested when the pull request is marked ready for review kamil-tekiela is a code owner

@alexdowad alexdowad Awaiting requested review from alexdowad alexdowad will be requested when the pull request is marked ready for review alexdowad is a code owner

@youkidearitai youkidearitai Awaiting requested review from youkidearitai youkidearitai will be requested when the pull request is marked ready for review youkidearitai is a code owner

@adoy adoy Awaiting requested review from adoy adoy will be requested when the pull request is marked ready for review adoy is a code owner

Assignees
No one assigned
Labels
Category: Engine Category: Optimizer Extension: com_dotnet Extension: curl Extension: dom Extension: ffi Extension: filter Extension: intl Extension: json Extension: libxml Extension: mbstring Extension: mysqli Extension: mysqlnd Extension: oci8 Extension: opcache Extension: openssl Extension: pcre Extension: pdo_pgsql Extension: pdo_sqlite Extension: pgsql Extension: phar Extension: random Extension: session Extension: shmop Extension: simplexml Extension: soap Extension: sockets Extension: spl Extension: sqlite3 Extension: standard Extension: sysvmsg Extension: zend_test Extension: zlib SAPI: cgi SAPI: cli SAPI: fpm SAPI: phpdbg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MaxKellermann @codecov-commenter @smalyshev @nbish11 @dstogov @devnexen