Skip to content

opcache should not be honored by --EXTENSIONS-- section when run in CI #8738

@mvorisek

Description

@mvorisek

Description

Currently, especially the JIT tests, require opcache ext via --EXTENSIONS-- section.

I belive that is suboptimal, as all such tests should be run also /wo opcache to test if the expectations are matched also /wo opcache ext.

This applies only for CI (GitHub Actions, ...) where we run all tests /w and /wo opcache. In nightly, we run all tests even with multiple opcache.jit variants.

Therefore I propose additional test parameter for run-tests.php which will accept a matrix in JSON format of all tested ini configurations like:

[
  {
    "ext-opcache": false
  },
  {
    "ext-opcache": true,
    "opcache.jit": 1255
  },
  {
    "ext-opcache": true,
    "opcache.jit": 1235
  }
]

and when:

a) a test requires opcache ext, the requirement will be ignored, as thanks to 2nd (and 3rd) test matrix config, we are guaranteed this required/prefered configuration will be tested
b) a test requires specific ini option like opcache.jit=1255, it will be ignored as well, as again, this config is guaranteed to be tested in other run

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions