Skip to content

Bump ICU version requirement #16659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cmb69 opened this issue Oct 31, 2024 · 2 comments
Closed

Bump ICU version requirement #16659

cmb69 opened this issue Oct 31, 2024 · 2 comments
Assignees
@cmb69
Labels
Extension: intl Feature Status: Verified

Comments

@cmb69
Copy link
Member

cmb69 commented Oct 31, 2024

Description

The last time this has been done for PHP 7.4[1]; since then the requirement is ICU >= 50.1, which has been released 12 years ago. In my opinion, we should bump the requirement (not sure exactly to which version though). That may allow us to drop some conditional compilation, and also some test cases for old ICU versions. E.g.

php-src/ext/intl/tests/collator_get_sort_key_variant2.phpt

Line 7 in f5e743a

<?php if (version_compare(INTL_ICU_VERSION, '53.1') >= 0) die('skip for ICU < 53.1'); ?>

Note that ICU 53.1 has been released more than 10 years ago.

[1] 20fa2e7
@devnexen
Copy link
Member

I would say at least 57.1 as Solaris 11 can get it from opencsw. We, normally, plan to drop centos 7 support for the next major php release and centos 8 it s 60.3 but might be a bit too "recent" tough (2019).

@cmb69
Copy link
Member Author

cmb69 commented Oct 31, 2024

Okay, I'll work on a PR.

@cmb69 cmb69 self-assigned this Oct 31, 2024
@cmb69 cmb69 mentioned this issue Oct 31, 2024
Merged
cmb69 added a commit to cmb69/php-src that referenced this issue Nov 3, 2024
@cmb69
Close phpGH-16659: Bump ICU requirement to ICU >= 57.1
5152b31 
This requirements bump should rarely affect anybody in practice.  All
major distros already ship more recent ICU versions, and even for
Solaris 11, ICU 57.1 is available via OpenCSW.  Note that ICU 57.1 has
been released on 2016-03-23[1].

[1] <https://icu.unicode.org/download/57>
@cmb69 cmb69 linked a pull request Nov 3, 2024 that will close this issue
Close GH-16659: Bump ICU requirement to ICU >= 57.1 #16688
Closed
@cmb69 cmb69 closed this as completed in 3815a77 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmb69 cmb69

Labels
Extension: intl Feature Status: Verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close GH-16659: Bump ICU requirement to ICU >= 57.1 cmb69/php-src
2 participants
@cmb69 @devnexen