2 tests fail on Alpinelinux s390x

[andypost]

Description

Preparing a next release the rebuild required to upgrade to RC1 for new libxml but 2 tests fail using clang 18.1.8

The following failure #15168

TEST 8148/17152 [ext/json/tests/gh15168.phpt]
========DIFF========
     bool(false)
     int(1)
     string(28) "Maximum stack depth exceeded"
+ 
+ Termsig=0
========DONE========
�[1;31mFAIL�[0m GH-15168 (stack overflow in json_encode()) [ext/json/tests/gh15168.phpt] 

and another one #15169

TEST 15215/17151 [ext/standard/tests/serialize/gh15169.phpt]
========DIFF========
     Maximum call stack size reached. Infinite recursion?
�[1;32m002+ �[0m
�[1;32m003+ Termsig=0�[0m
========DONE========
�[1;31mFAIL�[0m GH-15169 (stack overflow when var serialization in ext/standard/var) [ext/standard/tests/serialize/gh15169.phpt] 

PHP Version

PHP 8.3.13RC1

Operating System

Alpinelinux

[iluuu1994]

@andypost Can you check if this SKIPIF solves the problem for you?

if (!function_exists('zend_test_zend_call_stack_get')) die("skip zend_test_zend_call_stack_get() is not available");

I'm assuming the other stack limit tests also get skipped? E.g. Zend/tests/stack_limit/stack_limit_001.phpt

[andypost]

I bet the function should exist as I do build zend_test module and other arches are passing tests

Moreover both tests passing in CI but fails on builder... so I'm lost a bit

[andypost]

@iluuu1994 you can see full log from CI - all tests are executed and passed

[andypost]

And here's a build log from builder

[iluuu1994]

@andypost These methods exist conditionally, namely when ZEND_CHECK_STACK_LIMIT is declared.

I can't see stack_limit_001.phpt in your output, so are you sure you are compiling with zend_test? I can see them in the second log, where the new tests are also passing.

[andypost]

Yes, it's here in raw log

TEST 4153/17152 [Zend/tests/stack_limit/stack_limit_001.phpt]
�[1;32mPASS�[0m Stack limit 001 - Stack limit checks with max_allowed_stack_size detection [Zend/tests/stack_limit/stack_limit_001.phpt] 

[andypost]

The --enable-zend-test https://gitlab.alpinelinux.org/alpine/aports/-/blob/43a1a2c49009966acb0db6d8a20fe5785dbfffc8/community/php83/APKBUILD#L342

[iluuu1994]

Yes, it's here in raw log

But the two new tests are also passing in this build. Do you have one where:

• stack_limit_001.phpt is running (and passing)
• gh15168.phpt and gh15169.phpt are running (and failing)

[andypost]

And here's a build log from builder

Here it was but env is the same just tests removed, in CI it passed as you see in full log

[iluuu1994]

Ok, gotcha. Unfortunately, I don't know then.

[cmb69]

What does Termsig=0 mean? Has the test perhaps terminated, possibly because it took too long?

[arnaud-lb]

A possibility is that the test is overflowing the stack during dtor of $firstNode (I'm not sure why Termsig would be 0 in this case however).

@andypost are you able to run the test suite with this patch? https://github.com/arnaud-lb/php-src/commit/5a279639bbc1fd9a34e48c359612e40c0b98e162.diff

[andypost]

As I get PHP 8.3.13 and 8.4RC3 both randomly fails this test, used to build with clang 19.1.1 but gh15168 still fail - log

@arnaud-lb gonna apply patch and will report

[andypost]

@arnaud-lb thank you! patch works somehow)