str_getcsv returns null byte for unterminated quoted string

[apeschar]

Description

The following code:

<?php
echo json_encode(str_getcsv("\""));

Resulted in this output:

["\u0000"]

But I expected this output instead:

[""]

https://3v4l.org/TI1vo

PHP Version

PHP 5.3.0 to now

Operating System

No response

[Girgias]

This behaviour dates back to its introduction in PHP 5.3, at this point I think the ship has sailed on "sensible" behaviour for this function. I really need to go back and work onext/csv.

But @bukka what do you think about this?

[bukka]

I have done some debugging and I think this might be actually a bug that is worth a fix. I see the point about the BC as some apps might potentially rely on that but I think we could still fix it in 8.3 potentially. Specifically this output really does not make any sense to me:

<?php
var_dump(str_getcsv('"","a'));
var_dump(str_getcsv('"","'));

results to

array(2) {
  [0]=>
  string(0) ""
  [1]=>
  string(1) "a"
}
array(2) {
  [0]=>
  string(0) ""
  [1]=>
  string(1) ""
}

As can be seen the current logic is to ignore missing enclosing character at the end. But in the case of empty strings, it prints \0 which seems like a omission in the code to me as it twice increments bptr without checking for end.

[bukka]

The fix for this is in GH-12047 . It took me quite a bit of time to just figure out how that old (created 20 years ago) parser works. At least I have got some knowledge of that now...