Skip to content

Commit 7cc327f

Browse files
committed
Dynamically xfail test case which fails on CI
This is a stop-gap measure for GH-15709 to keep CI green. Sorry, xfailed the wrong test case previously.
1 parent bdde797 commit 7cc327f

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

Zend/tests/gh16508.phpt

-11
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,6 @@
22
GH-16508: Missing lineno in inheritance errors of delayed early bound classes
33
--EXTENSIONS--
44
opcache
5-
--SKIPIF--
6-
<?php
7-
$tracing = extension_loaded("Zend OPcache")
8-
&& ($conf = opcache_get_configuration()["directives"])
9-
&& array_key_exists("opcache.jit", $conf)
10-
&& $conf["opcache.jit"] === "tracing";
11-
if (PHP_OS_FAMILY === "Windows" && PHP_INT_SIZE == 8 && $tracing) {
12-
$url = "https://github.com/php/php-src/pull/14919#issuecomment-2259003979";
13-
die("xfail Test fails on Windows x64 (VS17) and tracing JIT; see $url");
14-
}
15-
?>
165
--INI--
176
opcache.enable_cli=1
187
--FILE--

Zend/tests/gh16509.phpt

+11
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
--TEST--
22
GH-16509: Incorrect lineno reported for function redeclaration
3+
--SKIPIF--
4+
<?php
5+
$tracing = extension_loaded("Zend OPcache")
6+
&& ($conf = opcache_get_configuration()["directives"])
7+
&& array_key_exists("opcache.jit", $conf)
8+
&& $conf["opcache.jit"] === "tracing";
9+
if (PHP_OS_FAMILY === "Windows" && PHP_INT_SIZE == 8 && $tracing) {
10+
$url = "https://github.com/php/php-src/pull/14919#issuecomment-2259003979";
11+
die("xfail Test fails on Windows x64 (VS17) and tracing JIT; see $url");
12+
}
13+
?>
314
--FILE--
415
<?php
516

0 commit comments

Comments
 (0)