Skip to content

Binary string deprecation #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

pmmaga
Copy link
Contributor

@pmmaga pmmaga commented Jan 19, 2017

This PR is part of the Binary string deprecation RFC.

The PR for php-src can be found here

@Hywan
Copy link
Contributor

Hywan commented Jan 20, 2017

Keep in mind that the RFC has not been voted yet. Must not merge this PR yet.

@Hywan
Copy link
Contributor

Hywan commented Jan 20, 2017

And thanks for the PR :-).

@nikic nikic added the RFC label Jan 20, 2017
@nikic
Copy link
Member

nikic commented Jan 20, 2017

As the actual removal will only happen in PHP 8, shouldn't this patch only specify deprecation?

@pmmaga
Copy link
Contributor Author

pmmaga commented Jan 20, 2017

Sure, I can change it to mention the deprecation on the text files then. About the test, should I keep it there as well then?

@pmmaga pmmaga force-pushed the binary-string-deprecation branch from 15f1910 to 50f65a1 Compare January 20, 2017 20:28
@pmmaga pmmaga force-pushed the binary-string-deprecation branch from 50f65a1 to 4bd6003 Compare January 20, 2017 20:46
@pmmaga
Copy link
Contributor Author

pmmaga commented Jan 20, 2017

I've updated the PR to reflect the deprecation phase.

@pmmaga
Copy link
Contributor Author

pmmaga commented Feb 20, 2017

Closing as the RFC was rejected

@pmmaga pmmaga closed this Feb 20, 2017
@padrecedano
Copy link

padrecedano commented Sep 19, 2017

@pmmaga Do you know why this RFC was rejected? And, it can be deprecated in PHP 8? Thanks.

@pmmaga
Copy link
Contributor Author

pmmaga commented Sep 19, 2017

@padrecedano you can find the discussion here and more here The RFC itself is found here. Given the rejection, it is very unlikely it will get deprecated any time soon.

@padrecedano
Copy link

@pmmaga thanks for the fast response and for the discussion links!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants