fix #250: non-null-terminated zend_string in s_decompress_value #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
Author
|
could you help to review the PR and accept it if it looks good to you? it should fix #250 and we have several positive feedback at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a potential bug is introduced in dc5b22a#diff-f76062ebbcf30f0491af9ca937d17762R3270
the null-termination is missed during conversion; while zend_string_init did it correctly
https://github.com/php/php-src/blob/master/Zend/zend_string.h#L156
potential fix for #250
credit: thanks to my colleague @yuripave isolate the issue to the abovementioned commit. it makes further analysis much easier