Skip to content

fix #250: non-null-terminated zend_string in s_decompress_value #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2016

Conversation

dictcp
Copy link
Contributor

@dictcp dictcp commented Jun 8, 2016

a potential bug is introduced in dc5b22a#diff-f76062ebbcf30f0491af9ca937d17762R3270

the null-termination is missed during conversion; while zend_string_init did it correctly
https://github.com/php/php-src/blob/master/Zend/zend_string.h#L156

potential fix for #250


credit: thanks to my colleague @yuripave isolate the issue to the abovementioned commit. it makes further analysis much easier

@dictcp dictcp changed the title fix: null-terminated zend_string in s_decompress_value fix: non-null-terminated zend_string in s_decompress_value Jun 8, 2016
@dick9gag dick9gag mentioned this pull request Jun 8, 2016
@dictcp dictcp changed the title fix: non-null-terminated zend_string in s_decompress_value fix #250: non-null-terminated zend_string in s_decompress_value Jun 8, 2016
@dictcp
Copy link
Contributor Author

dictcp commented Jun 9, 2016

@krakjoe @mkoppanen

could you help to review the PR and accept it if it looks good to you?

it should fix #250 and we have several positive feedback at
#250 (comment)

@krakjoe krakjoe merged commit 0986493 into php-memcached-dev:php7 Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants