Document miscellaneous ini settings and new defaults for PHP7 release #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates some of the memcached.ini documentation settings to reflect the default ini settings used in php_memcached.c. Some new settings were added, and other settings had changes to their defaults. There are other new/updated settings, which can be changed in other PRs. For issue php-memcached-dev#233
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates some of the memcached.ini documentation settings
to reflect the default ini settings used in php_memcached.c.
Some new settings were added, and other settings had changes to their defaults.
There are other new/updated settings, which can be changed in other PRs.
I not completely certain of what memcached.server_failure_limit does and why it would be overriden, and http://docs.libmemcached.org/memcached_behavior.html#MEMCACHED_BEHAVIOR_REMOVE_FAILED_SERVERS says that MEMCACHED_BEHAVIOR_SERVER_FAILURE_LIMIT was deprecated, so I'd prefer it if a contributor documented that setting outside of this PR.
For issue #233