This repository was archived by the owner on Jan 16, 2018. It is now read-only.
Update HttpMethodsClient.php #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altered order of arguments to match interfaces project-wide.
|
Thanks @Swader |
sagikazarmark
added a commit
that referenced
this pull request
Oct 31, 2015
Update HttpMethodsClient to reflect changes in the MessageFactory
| $headers, | ||
| $body | ||
| $body, | ||
| '1.1' |
There was a problem hiding this comment.
as this is not an argument to the HttpMethodsClient::send method, i would remove it and let the default happen. otherwise we duplicate default values. i guess it does not matter all that much but would seem cleaner...
dbu
added a commit
that referenced
this pull request
Nov 1, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altered order of arguments to match interfaces project-wide.