Add .cjs file extension support
#1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Node 13.2.0, the `--experimental-modules` flag was removed making usage of ES modules available by default. As part of the Node ES modules support, they allow a package to define their default module type (which is how `.js` files are interpretted) and also allow using either `.cjs` or `.mjs` to explicitly declare a given file is of one format or the other. We already had the `.mjs` extension supported so this adds `.cjs` to round out support for Node's ES module system. References: * [v13.2.0 release post unflagging `--experimental-modules`](https://nodejs.org/en/blog/release/v13.2.0/) * [v14 documentation of ES Modules](https://nodejs.org/api/esm.html)
|
Thanks for this! |
|
i'm using spacevim and wondering is this project part of it or not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Node 13.2.0, the
--experimental-modulesflag was removed making usage of ES modules available by default. As part of the Node ES modules support, they allow a package to define their default module type (which is how.jsfiles are interpretted) and also allow using either.cjsor.mjsto explicitly declare a given file is of one format or the other.We already had the
.mjsextension supported so this adds.cjsto round out support for Node's ES module system.References:
--experimental-modules