Add filter revealjs-codeblock #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! It will take me a little longer to review, but should be able to do so next week. |
tarleb
approved these changes
Jul 25, 2020
| end | ||
|
|
||
| function CodeBlock(block) | ||
| if FORMAT == 'revealjs' then |
There was a problem hiding this comment.
This could go to the top of the file, like so:
if FORMAT ~= 'revealjs' then
return {}
endThat way the filter can exit early and the code becomes a little less nested.
| end | ||
|
|
||
| local function is_data_line_number_in_attributes(attributes) | ||
| for _, attribute in ipairs(attributes) do |
There was a problem hiding this comment.
Attributes come with a metatable which allows using the structure just like an associative table. E.g., this could be written as
for key, value in pairs(attributes) do
if key == 'data-line-numbers' then return true end
endWe would have changed the ipairs behavior as well, but Lua 5.3 does not allow this.
| end | ||
| if block.identifier ~= '' then | ||
| table.insert(pre_tag_attributes, | ||
| string.format('id="%s"', block.identifier)) |
There was a problem hiding this comment.
This could be extracted in a separate function like html_attr or the like.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a filter that passes code block attributes to
revealjsHTML output to enable reveal.js code presentation features like line numbers & highlights, step-by-step highlights and auto-animation.