BUG: correct Period comparisons #7379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks ok |
|
I'm not sure I really understand the implications of the change, but looks harmless enough? Should probably go in the release notes if for some reason someone was relying on the TypeError being raised. The rest of the magic methods still raise a TypeError, though I doubt it's worth worrying about consistency here? I can't see much of a reason for it. |
|
yep there will be a doc blurb in v0.14.1.txt |
if no comparison is implemented
cpcloud
added a commit
that referenced
this pull request
Jun 6, 2014
BUG: correct Period comparisons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7376