Skip to content

BUG: .mode(dropna=False) doesn't work with nullable integers #61132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2025
Merged

BUG: .mode(dropna=False) doesn't work with nullable integers #61132

merged 3 commits into from
Mar 17, 2025

Conversation

halogen22
Copy link
Contributor

@halogen22 halogen22 commented Mar 16, 2025 •
edited
Loading

Issue #58926
Edited pandas.core.algorithms.mode function so that mode(dropna=False) works with nullable integers.
PR of others before: #58931

@halogen22 halogen22 requested a review from WillAyd as a code owner March 16, 2025 10:09
@mroeschke mroeschke added the NA - MaskedArrays Related to pd.NA and nullable extension arrays label Mar 17, 2025
@mroeschke mroeschke added this to the 3.0 milestone Mar 17, 2025
@mroeschke mroeschke merged commit 1e899af into pandas-dev:main Mar 17, 2025
46 checks passed
@mroeschke
Copy link
Member

Thanks @halogen22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@WillAyd WillAyd Awaiting requested review from WillAyd

Assignees
No one assigned
Labels
NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

BUG: .mode(dropna=False) doesn't work with nullable integers
2 participants
@halogen22 @mroeschke