Skip to content

Replace khash + tempita with khashl #57730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 43 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
3cac2bc
updated gitignore
WillAyd Mar 1, 2024
03b2e3e
initial setup
WillAyd Mar 1, 2024
d90bbe3
Working compilation
WillAyd Mar 4, 2024
07a08c6
Working vector implementation
WillAyd Mar 4, 2024
0af85e6
Some algorithms
WillAyd Mar 4, 2024
f2bcb07
compile time masking
WillAyd Mar 4, 2024
c6e695a
Unique variations
WillAyd Mar 4, 2024
0f11e28
Passing tests
WillAyd Mar 5, 2024
becf054
Merge remote-tracking branch 'upstream/main' into khashl-usage
WillAyd Mar 5, 2024
e5c1e30
remove old files
WillAyd Mar 5, 2024
8f95657
Add cmake dependencies
WillAyd Mar 5, 2024
32b4b96
fix wraps file
WillAyd Mar 5, 2024
9112b8f
meson requirements
WillAyd Mar 5, 2024
081dd7c
Meson version bump in CI
WillAyd Mar 5, 2024
b4d49b3
asan meson bump
WillAyd Mar 5, 2024
23fc584
perf + build warning fixes
WillAyd Mar 5, 2024
57c6517
no copy, release GIL
WillAyd Mar 5, 2024
03d31aa
fixes
WillAyd Mar 5, 2024
90a55c1
fixes
WillAyd Mar 5, 2024
b0caf3b
missing header
WillAyd Mar 5, 2024
550a72c
fix Py_ssize_t
WillAyd Mar 5, 2024
77299e2
Build warning fixes (hopefully)
WillAyd Mar 5, 2024
e4ee5b5
try 64 bit khint_t
WillAyd Mar 5, 2024
cf7d794
fix
WillAyd Mar 5, 2024
86da145
Revert "fix"
WillAyd Mar 6, 2024
9a0e09b
Revert "try 64 bit khint_t"
WillAyd Mar 6, 2024
4235d15
use more auto
WillAyd Mar 6, 2024
76bed79
Use custom kh_int_t
WillAyd Mar 6, 2024
e306e2a
Try templated khint_t
WillAyd Mar 6, 2024
33caa61
Fix sizing of hash functions
WillAyd Mar 6, 2024
020cfe5
fix std::max
WillAyd Mar 6, 2024
562df98
remove const-ness for data members
WillAyd Mar 6, 2024
79323c8
Suppress leak warnings for now
WillAyd Mar 6, 2024
899fe02
undefine NB_ABORT_ON_LEAK
WillAyd Mar 7, 2024
27e92d6
Use factorizers in reshape
WillAyd Mar 7, 2024
defedd2
Fix 32 bit init
WillAyd Mar 7, 2024
ea26faa
Revert "Use factorizers in reshape"
WillAyd Mar 7, 2024
86b1b7e
Skip pytables test
WillAyd Mar 7, 2024
771fe48
cleanup / simplifications
WillAyd Mar 7, 2024
2cb2e40
test fixes
WillAyd Mar 7, 2024
0ae5084
Container resizing
WillAyd Mar 8, 2024
0db5f0c
CI fixes
WillAyd Mar 8, 2024
b8759ce
improvements / fixes
WillAyd Mar 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- run: |
/opt/python/cp311-cp311/bin/python -m venv ~/virtualenvs/pandas-dev
. ~/virtualenvs/pandas-dev/bin/activate
python -m pip install --no-cache-dir -U pip wheel setuptools meson-python==0.13.1 meson[ninja]==1.2.1
python -m pip install --no-cache-dir -U pip wheel setuptools meson-python==0.13.1 meson[ninja]==1.3.0
python -m pip install --no-cache-dir versioneer[toml] cython numpy python-dateutil pytz pytest>=7.3.2 pytest-xdist>=2.2.0 hypothesis>=6.46.1
python -m pip install --no-cache-dir --no-build-isolation -e . --config-settings=setup-args="--werror"
python -m pip list --no-cache-dir
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ jobs:
run: |
/opt/python/cp311-cp311/bin/python -m venv ~/virtualenvs/pandas-dev
. ~/virtualenvs/pandas-dev/bin/activate
python -m pip install --no-cache-dir -U pip wheel setuptools meson[ninja]==1.2.1 meson-python==0.13.1
python -m pip install --no-cache-dir -U pip wheel setuptools meson[ninja]==1.3.0 meson-python==0.13.1
python -m pip install numpy --config-settings=setup-args="-Dallow-noblas=true"
python -m pip install --no-cache-dir versioneer[toml] cython python-dateutil pytz pytest>=7.3.2 pytest-xdist>=2.2.0 hypothesis>=6.46.1
python -m pip install --no-cache-dir --no-build-isolation -e . --config-settings=setup-args="--werror"
Expand Down Expand Up @@ -279,7 +279,7 @@ jobs:
run: |
/opt/python/cp311-cp311/bin/python -m venv ~/virtualenvs/pandas-dev
. ~/virtualenvs/pandas-dev/bin/activate
python -m pip install --no-cache-dir -U pip wheel setuptools meson-python==0.13.1 meson[ninja]==1.2.1
python -m pip install --no-cache-dir -U pip wheel setuptools meson-python==0.13.1 meson[ninja]==1.3.0
python -m pip install --no-cache-dir versioneer[toml] cython numpy python-dateutil pytz pytest>=7.3.2 pytest-xdist>=2.2.0 hypothesis>=6.46.1
python -m pip install --no-cache-dir --no-build-isolation -e . --config-settings=setup-args="--werror"
python -m pip list --no-cache-dir
Expand Down Expand Up @@ -351,7 +351,7 @@ jobs:
- name: Build Environment
run: |
python --version
python -m pip install --upgrade pip setuptools wheel meson[ninja]==1.2.1 meson-python==0.13.1
python -m pip install --upgrade pip setuptools wheel meson[ninja]==1.3.0 meson-python==0.13.1
python -m pip install --pre --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple numpy
python -m pip install versioneer[toml]
python -m pip install python-dateutil pytz tzdata cython hypothesis>=6.46.1 pytest>=7.3.2 pytest-xdist>=2.2.0 pytest-cov
Expand Down
6 changes: 3 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@ scikits
!skts.c
*.c
*.cpp
!pandas/_libs/src/**/*.c
!pandas/_libs/src/**/*.h
!pandas/_libs/include/**/*.h
!pandas/_libs/src/**/*.c*
!pandas/_libs/src/**/*.h*
!pandas/_libs/include/**/*.h*

# Unit / Performance Testing #
##############################
Expand Down
1 change: 1 addition & 0 deletions asv_bench/asv.conf.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"xlrd": [],
"odfpy": [],
"jinja2": [],
"cmake": [],
"meson": [],
"meson-python": [],
"python-build": [],
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/actions-310.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dependencies:
# build dependencies
- versioneer[toml]
- cython>=0.29.33
- meson[ninja]=1.2.1
- meson[ninja]=1.3.0
- meson-python=0.13.1

# test dependencies
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/actions-311-downstream_compat.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ dependencies:
# build dependencies
- versioneer[toml]
- cython>=0.29.33
- meson[ninja]=1.2.1
- meson[ninja]=1.3.0
- meson-python=0.13.1

# test dependencies
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/actions-311-numpydev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:

# build dependencies
- versioneer[toml]
- meson[ninja]=1.2.1
- meson[ninja]=1.3.0
- meson-python=0.13.1
- cython>=0.29.33

Expand Down
2 changes: 1 addition & 1 deletion ci/deps/actions-311-pyarrownightly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:

# build dependencies
- versioneer[toml]
- meson[ninja]=1.2.1
- meson[ninja]=1.3.0
- cython>=0.29.33
- meson-python=0.13.1

Expand Down
2 changes: 1 addition & 1 deletion ci/deps/actions-311-sanitizers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dependencies:
# build dependencies
- versioneer[toml]
- cython>=0.29.33
- meson[ninja]=1.2.1
- meson[ninja]=1.3.0
- meson-python=0.13.1

# test dependencies
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/actions-311.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dependencies:
# build dependencies
- versioneer[toml]
- cython>=0.29.33
- meson[ninja]=1.2.1
- meson[ninja]=1.3.0
- meson-python=0.13.1

# test dependencies
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/actions-312.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dependencies:
# build dependencies
- versioneer[toml]
- cython>=0.29.33
- meson[ninja]=1.2.1
- meson[ninja]=1.3.0
- meson-python=0.13.1

# test dependencies
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/actions-39-minimum_versions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies:
# build dependencies
- versioneer[toml]
- cython>=0.29.33
- meson[ninja]=1.2.1
- meson[ninja]=1.3.0
- meson-python=0.13.1

# test dependencies
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/actions-39.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dependencies:
# build dependencies
- versioneer[toml]
- cython>=0.29.33
- meson[ninja]=1.2.1
- meson[ninja]=1.3.0
- meson-python=0.13.1

# test dependencies
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/actions-pypy-39.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dependencies:
# build dependencies
- versioneer[toml]
- cython>=0.29.33
- meson[ninja]=1.2.1
- meson[ninja]=1.3.0
- meson-python=0.13.1

# test dependencies
Expand Down
2 changes: 1 addition & 1 deletion ci/deps/circle-310-arm64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dependencies:
# build dependencies
- versioneer[toml]
- cython>=0.29.33
- meson[ninja]=1.2.1
- meson[ninja]=1.3.0
- meson-python=0.13.1

# test dependencies
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies:
# build dependencies
- versioneer[toml]
- cython~=3.0.5
- meson[ninja]=1.2.1
- meson[ninja]=1.3.0
- meson-python=0.13.1

# test dependencies
Expand Down
3 changes: 2 additions & 1 deletion meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ project(
'c', 'cpp', 'cython',
version: run_command(['generate_version.py', '--print'], check: true).stdout().strip(),
license: 'BSD-3',
meson_version: '>=1.2.1',
meson_version: '>=1.3.0',
default_options: [
'buildtype=release',
'c_std=c11',
'cpp_std=c++17',
'warning_level=2',
]
)
Expand Down
2 changes: 0 additions & 2 deletions pandas/_libs/hashtable.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,8 @@ include "hashtable_func_helper.pxi"

# map derived hash-map types onto basic hash-map types:
if np.dtype(np.intp) == np.dtype(np.int64):
IntpHashTable = Int64HashTable
unique_label_indices = _unique_label_indices_int64
elif np.dtype(np.intp) == np.dtype(np.int32):
IntpHashTable = Int32HashTable
unique_label_indices = _unique_label_indices_int32
else:
raise ValueError(np.dtype(np.intp))
Expand Down
Loading