Skip to content

DEP: Deprecate non boolean sort for concat #44629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2021
Merged

DEP: Deprecate non boolean sort for concat #44629

merged 2 commits into from
Nov 28, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 26, 2021

@phofl phofl added Deprecate Functionality to remove in pandas Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Nov 26, 2021
mroeschke
mroeschke approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green

@mroeschke mroeschke added this to the 1.4 milestone Nov 26, 2021
@phofl phofl mentioned this pull request Nov 26, 2021
Closed
@phofl
Copy link
Member Author

phofl commented Nov 27, 2021

sort=sort in this test caused sort=None, fixed that

jreback
jreback reviewed Nov 27, 2021
View reviewed changes
@jreback jreback merged commit 845d164 into pandas-dev:master Nov 28, 2021
@phofl phofl deleted the 41518 branch November 28, 2021 01:34
@lukemanley lukemanley mentioned this pull request Nov 2, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

Docs issue for pd.concat
3 participants
@phofl @jreback @mroeschke