Skip to content

Conversation

Anupam-USP
Copy link
Contributor

@Anupam-USP Anupam-USP commented May 25, 2021

@pep8speaks
Copy link

pep8speaks commented May 25, 2021

Hello @Anupam-USP! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-27 12:58:55 UTC

@simonjayhawkins simonjayhawkins added the Deprecate Functionality to remove in pandas label May 25, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone May 25, 2021
@jreback jreback removed this from the 1.3 milestone May 26, 2021
@jreback
Copy link
Contributor

jreback commented May 26, 2021

@Anupam-USP pls rebase & fix this up; ping when ready for a look.

@Anupam-USP
Copy link
Contributor Author

@Anupam-USP pls rebase & fix this up; ping when ready for a look.

Yes I am woking on it, but haven't got any conclusive solutions. Can you please help me?

@simonjayhawkins
Copy link
Member

@jreback I added the milestone since I think we want to get all these deprecations in at the same time?

@jreback
Copy link
Contributor

jreback commented May 26, 2021

@simonjayhawkins i understand but this one is not ready

@simonjayhawkins
Copy link
Member

@MarcoGorelli can you help push this over the line.

@Anupam-USP
Copy link
Contributor Author

Is there anything I can do to resolve the issue?

@simonjayhawkins
Copy link
Member

Yes I am woking on it, but haven't got any conclusive solutions. Can you please help me?

what is the issue? do the ci logs not help?

@Anupam-USP
Copy link
Contributor Author

I am new to the ci logs and not able to find the solution of the them. Can you help me?

@MarcoGorelli
Copy link
Member

Hey @Anupam-USP - no worries, I've added a commit this time fixing it up due to time constraints, next time I'll help out

@Anupam-USP
Copy link
Contributor Author

Okay @MarcoGorelli ! Though I wasn't fully able to resolve this issue but this was my very first PR. Thank you

@simonjayhawkins
Copy link
Member

@MarcoGorelli MarcoGorelli added this to the 1.3 milestone May 27, 2021
@MarcoGorelli
Copy link
Member

Thanks @Anupam-USP for having started this one - if you look at what's been changed and try resample.interpolate then I think we can get that one in too

@MarcoGorelli MarcoGorelli merged commit 91bd03b into pandas-dev:master May 27, 2021
@lithomas1 lithomas1 added the IO CSV read_csv, to_csv label May 28, 2021
@lithomas1
Copy link
Contributor

Hi @MarcoGorelli @simonjayhawkins,
It looks like this is only done for read_csv, but it would probably be better if this were also done for read_table too, given that they are pretty much the same function. (Also, would it possible to add this to the deprecation log (#30228) where the deprecations are tracked?)
Thanks

@Anupam-USP
Copy link
Contributor Author

I can try it, if it is available @simonjayhawkins @MarcoGorelli

@MarcoGorelli
Copy link
Member

I think that's a good suggestion, thanks @lithomas1 ! Any others you think of, can you add them to #41657?

TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
Co-authored-by: Marco Gorelli <[email protected]>
Co-authored-by: Simon Hawkins <[email protected]>
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Co-authored-by: Marco Gorelli <[email protected]>
Co-authored-by: Simon Hawkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants