Skip to content

Bug in loc raising KeyError when MultiIndex columns has only one level #38026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 25, 2020
Merged

Bug in loc raising KeyError when MultiIndex columns has only one level #38026

merged 4 commits into from
Nov 25, 2020

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 23, 2020

@jbrockmendel I think we should check for MultiIndex instead of level number here

@phofl phofl added Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex labels Nov 23, 2020
jbrockmendel
jbrockmendel reviewed Nov 23, 2020
View reviewed changes
@jbrockmendel
Copy link
Member

comment on test placement, otherwise LGTM

ApamNapat
ApamNapat reviewed Nov 24, 2020
View reviewed changes
jbrockmendel
jbrockmendel approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreback jreback added this to the 1.2 milestone Nov 25, 2020
@jreback jreback merged commit 5f5350b into pandas-dev:master Nov 25, 2020
@jreback
Copy link
Contributor

jreback commented Nov 25, 2020

thanks @phofl very nice
keep em coming!

@phofl phofl deleted the 29749 branch November 25, 2020 18:50
@jbrockmendel jbrockmendel mentioned this pull request Oct 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@jbrockmendel jbrockmendel jbrockmendel approved these changes

+1 more reviewer

@ApamNapat ApamNapat ApamNapat left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

Multiindex with single level no longer allows selecting columns
4 participants
@phofl @jbrockmendel @jreback @ApamNapat