Skip to content

Bug in DataFrame.loc returning elements in wrong order when indexer is differently ordered than object #37992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 25, 2020
Merged

Bug in DataFrame.loc returning elements in wrong order when indexer is differently ordered than object #37992

merged 8 commits into from
Nov 25, 2020

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 22, 2020

@phofl phofl added Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex labels Nov 22, 2020
@jreback jreback added this to the 1.2 milestone Nov 24, 2020
jreback
jreback approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @jbrockmendel if you can have a look.

jbrockmendel
jbrockmendel reviewed Nov 24, 2020
View reviewed changes
jbrockmendel
jbrockmendel reviewed Nov 24, 2020
View reviewed changes
@jbrockmendel
Copy link
Member

LGTM thanks for hunting these down @phofl

@phofl
Merge branch 'master' of https://github.com/pandas-dev/pandas into 34…
f43e2bd 
…603_original

� Conflicts:
�	doc/source/whatsnew/v1.2.0.rst
�	pandas/tests/indexing/multiindex/test_loc.py
@jbrockmendel
Copy link
Member

needs rebase otherwise LGTM

jbrockmendel
jbrockmendel reviewed Nov 25, 2020
View reviewed changes
@phofl
Copy link
Member Author

phofl commented Nov 25, 2020

Thx for rebasing

@jreback jreback merged commit 15b8898 into pandas-dev:master Nov 25, 2020
@jreback
Copy link
Contributor

jreback commented Nov 25, 2020

thanks @phofl

@phofl phofl deleted the 34603 branch November 25, 2020 20:52
@simonjayhawkins simonjayhawkins mentioned this pull request Dec 22, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

BUG: dangerous inconsistency when setting values on slice of multi-index Rows order when using slice(None) on MultiIndex Dataframe.loc
3 participants
@phofl @jbrockmendel @jreback