Skip to content

REF: avoid special case in DTA/TDA.median, flesh out tests #37423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 31, 2020
Merged

REF: avoid special case in DTA/TDA.median, flesh out tests #37423

merged 7 commits into from
Oct 31, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Also fixes currently-incorrect empty case.

@jbrockmendel jbrockmendel mentioned this pull request Oct 28, 2020
Merged
5 tasks
@jreback jreback added this to the 1.2 milestone Oct 29, 2020
@jreback jreback added the Datetime Datetime data dtype label Oct 29, 2020
@jreback
Copy link
Contributor

jreback commented Oct 29, 2020

can you rebase

@jbrockmendel
Copy link
Member Author

Rebased + greenish

@jreback jreback merged commit 86ee235 into pandas-dev:master Oct 31, 2020
@jreback
Copy link
Contributor

jreback commented Oct 31, 2020

thanks

@jbrockmendel jbrockmendel deleted the ref-dtlike-mean-median branch October 31, 2020 20:53
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
REF: avoid special case in DTA/TDA.median, flesh out tests (pandas-de…
b5ee1bb 
…v#37423)
ukarroum pushed a commit to ukarroum/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel @ukarroum
REF: avoid special case in DTA/TDA.median, flesh out tests (pandas-de…
a079cb9 
…v#37423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Datetime Datetime data dtype
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback