ENH add na_action to DataFrame.applymap #35704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For symmetry with Series.map Fixes pandas-dev#23803
jreback
requested changes
Aug 14, 2020
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -50,6 +50,7 @@ For example: | |||
|
|
|||
| Other enhancements | |||
| ^^^^^^^^^^^^^^^^^^ | |||
| - :meth:`applymap` now supports ``na_action`` (:issue:`23803`) | |||
There was a problem hiding this comment.
this won't render, use DataFrame.applymap
There was a problem hiding this comment.
I was surprised by similar usage elsewhere in this file, which I copied:
https://github.com/pandas-dev/pandas/blob/6325a33/doc/source/whatsnew/v1.2.0.rst#L35
|
Apologies for my omissions! Thanks for the review. |
|
Failure appears unrelated |
|
looks good, can you merge master and ping on green. |
|
@jreback it's green :) |
jreback
approved these changes
Sep 11, 2020
|
thanks @jnothman very nice |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For symmetry with Series.map
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff