BUG: pd.crosstab fails when passed multiple columns, margins True and normalize True #35150
Conversation
| @@ -698,3 +698,46 @@ def test_margin_normalize(self): | |||
| names=["A", "B"], | |||
| ) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| def test_crosstab_multiple_columns_normalize(self): | |||
There was a problem hiding this comment.
is it possible to parametrize the tests added in #27663, would the results be the expected transposed?
There was a problem hiding this comment.
Wouldn't that result in a lot of overhead defining the parameters (inputs and results)? I actually see no easy way to refactor these usiing @pytest.mark.parametrize.
What do you mean by would the results be the expected transposed??
There was a problem hiding this comment.
thanks for the fix! just a couple nitpicks.
and as @simonjayhawkins said, you need to add a whatsnew note in 1.1.0.rst
78579a2 to
01217bc
Compare
|
can you merge master and will look again |
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -1166,6 +1166,7 @@ Reshaping | |||
| - Fixed bug in :func:`melt` where melting MultiIndex columns with ``col_level`` > 0 would raise a ``KeyError`` on ``id_vars`` (:issue:`34129`) | |||
| - Bug in :meth:`Series.where` with an empty Series and empty ``cond`` having non-bool dtype (:issue:`34592`) | |||
| - Fixed regression where :meth:`DataFrame.apply` would raise ``ValueError`` for elements whth ``S`` dtype (:issue:`34529`) | |||
| - Bug in func :meth:`crosstab` when using multiple columns with ``margins=True`` and ``normalize=True`` (:issue:`35144`) | |||
pandas/core/reshape/pivot.py
Outdated
| # index/column and save the column and index margin | ||
| if (margins_name not in table.iloc[-1, :].name) | ( | ||
| if (margins_name not in table.iloc[-1, :].name) & ( |
There was a problem hiding this comment.
can you pull out
table_name = table.iloc[-1, :].name and use that as a comparison
…x_normalize_crosstabbing
…x_normalize_crosstabbing
Done. @jreback I'll go on vacation on Friday would be great if we can get this done before that. Otherwise I'll finish this at the beginning of September. |
|
thanks @CloseChoice lgtm. |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff