ENH: Make Series.update() use objects coercible to Series #33502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c144b6 to
18c3cef
Compare
dsaxton
reviewed
Apr 23, 2020
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -98,6 +98,8 @@ Other enhancements | |||
| This can be used to set a custom compression level, e.g., | |||
| ``df.to_csv(path, compression={'method': 'gzip', 'compresslevel': 1}`` | |||
| (:issue:`33196`) | |||
| - :meth:`Series.update` now accepts objects that can be coerced to a Series, | |||
| such as `dict` and `list`, mirroring the behavior of `DataFrame.update` (:issue:`33215`) | |||
There was a problem hiding this comment.
You can use :class:`Series`, :meth:`DataFrame.update` and double back ticks around the other keywords for better rendering
|
|
||
| expected = Series([1, 5, 1, 4]) | ||
|
|
||
| tm.assert_series_equal(s, expected) |
There was a problem hiding this comment.
Do you think you could remove the excess white space and parametrize over the cases tested here?
dsaxton
reviewed
Apr 25, 2020
pandas/core/series.py
Outdated
| @@ -2764,7 +2764,7 @@ def combine_first(self, other) -> "Series": | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| other : Series | |||
| other : Series, or object coercible into Series | |||
There was a problem hiding this comment.
It looks like you're editing the docstring of combine_first, can you modify the one for update instead? @WillAyd do you think it'd be good to add an example to the docstring for this behavior?
jreback
requested changes
Apr 25, 2020
| ], | ||
| ) | ||
| def test_update_from_non_series(self, s, d, expected): | ||
| s.update(d) |
There was a problem hiding this comment.
can you add the issue number here as a comment
| (Series([1, 2, 3, 4]), [np.nan, 5, 1], Series([1, 5, 1, 4])), | ||
| ], | ||
| ) | ||
| def test_update_from_non_series(self, s, d, expected): |
There was a problem hiding this comment.
can you rename: s-> series, d-> other
jreback
approved these changes
Apr 26, 2020
|
thanks @dericke |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAllows
Series.update()to accept objects that can be coerced into aSeries, like adict. This mirrors the existing behavior ofDataFrame.update().