BUG: passing a non-dict mapping to pd.concat raises a TypeError #32953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the documentation of ``pandas.DataFrame.concat`` specifies that any mapping of ``Label`` to ``FrameOrSeries`` is acceptable as the first argument, the actual test performed checks for an instance of ``dict``. This changeset fixes that restriction.
This changeset adds a test asserting that pd.concat works as expected with an `objs` argument of type `Mapping`. It also replaces the explicit reference to the type `dict` in the corresponding entry of the docstring.
Co-Authored-By: Simon Hawkins <[email protected]>
…parametrize construct
jreback
requested changes
Mar 25, 2020
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -412,6 +414,7 @@ Other | |||
| - Fixed bug in :func:`pandas.testing.assert_series_equal` where dtypes were checked for ``Interval`` and ``ExtensionArray`` operands when ``check_dtype`` was ``False`` (:issue:`32747`) | |||
| - Bug in :meth:`Series.map` not raising on invalid ``na_action`` (:issue:`32815`) | |||
| - Bug in :meth:`DataFrame.__dir__` caused a segfault when using unicode surrogates in a column name (:issue:`25509`) | |||
| - Fixture :func:`non_mapping_dict_subclass` is now more appropriately called :func:`non_dict_mapping_subclass` (:issue:`32954`) | |||
There was a problem hiding this comment.
can you remove this; we don't add testing things to the release notes
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -385,8 +385,10 @@ Reshaping | |||
| - :meth:`DataFrame.replace` and :meth:`Series.replace` will raise a ``TypeError`` if ``to_replace`` is not an expected type. Previously the ``replace`` would fail silently (:issue:`18634`) | |||
| - Bug in :meth:`DataFrame.apply` where callback was called with :class:`Series` parameter even though ``raw=True`` requested. (:issue:`32423`) | |||
| - Bug in :meth:`DataFrame.pivot_table` losing timezone information when creating a :class:`MultiIndex` level from a column with timezone-aware dtype (:issue:`32558`) | |||
| - Bug in :meth:``pd.concat`` where when passing a non-dict mapping as ``objs`` would raise a TypeError (:issue:`32863`) | |||
There was a problem hiding this comment.
use :meth:`concat` instead
put double back-ticks around TypeError
5 tasks
jreback
approved these changes
Mar 26, 2020
|
thanks @pbourguignon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #32954
closes #32863
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff