BUG/TST: Add searchsorted tests #32874
Conversation
|
LGTM |
| tm.assert_numpy_array_equal(result, expected) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( |
There was a problem hiding this comment.
can you add a Timedelta & Period test cases here as well (followon PR is ok)
There was a problem hiding this comment.
actually if you'd do in this one
| tm.assert_numpy_array_equal(result, expected) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( |
There was a problem hiding this comment.
actually if you'd do in this one
pandas/core/arrays/datetimelike.py
Outdated
| @@ -804,6 +804,16 @@ def searchsorted(self, value, side="left", sorter=None): | |||
| indices : array of ints | |||
| Array of insertion points with the same shape as `value`. | |||
| """ | |||
| if is_list_like(value) and not isinstance(value, type(self)): | |||
There was a problem hiding this comment.
The tests added for PeriodIndex were failing so had to include this bug fix
There was a problem hiding this comment.
does this need to go before the str and _recognized_scalar checks below? IIRC putting them in this order is a pattern in this and related modules
There was a problem hiding this comment.
I don't think so, can move it down below
| ["2014-01-01", "2014-01-02", "2014-01-03", "2014-01-04", "2014-01-05"], | ||
| freq="D", | ||
| ) | ||
| result = pidx.searchsorted(klass(pidx)) |
There was a problem hiding this comment.
can you repeat this with pidx._data.searchsorted
| def test_searchsorted_different_argument_classes(klass): | ||
| # https://github.com/pandas-dev/pandas/issues/32762 | ||
| values = IntervalIndex([Interval(0, 1), Interval(1, 2)]) | ||
| result = values.searchsorted(klass(values)) |
There was a problem hiding this comment.
can you repeat with values._data.searchsorted
| if not type(self)._is_recognized_dtype(value): | ||
| raise TypeError( | ||
| "searchsorted requires compatible dtype or scalar, " | ||
| f"not {type(value).__name__}" | ||
| ) | ||
| value = type(self)(value) | ||
| self._check_compatible_with(value) | ||
|
|
||
| if not (isinstance(value, (self._scalar_type, type(self))) or (value is NaT)): |
There was a problem hiding this comment.
is this line actually hit by anything? 858), this seems very duplicative
| @@ -846,14 +846,14 @@ def searchsorted(self, value, side="left", sorter=None): | |||
| elif isinstance(value, self._recognized_scalars): | |||
| value = self._scalar_type(value) | |||
|
|
|||
| elif isinstance(value, np.ndarray): | |||
| if is_list_like(value) and not isinstance(value, type(self)): | |||
|
Carried over to #32764 since there's overlap |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffxref: #32845