BUG: Allow list-like in DatetimeIndex.searchsorted #32764
Conversation
| result = dates.searchsorted(klass(dates)) | ||
| expected = np.array([0, 1], dtype=result.dtype) | ||
|
|
||
| tm.assert_numpy_array_equal(result, expected) |
There was a problem hiding this comment.
do we have sufficient tests for if we have non-matching dtypes e.g. integers?
what about different timezones, or tzawareness-compat? (or periodarray freq mismatch)
There was a problem hiding this comment.
Added some tests for type mismatches
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "arg", [[1, 2], ["a", "b"], [pd.Timestamp("2020-01-01", tz="Europe/London")] * 2] |
There was a problem hiding this comment.
can you also test for a TDI and a PeriodIndex.
|
|
||
|
|
||
| @pytest.mark.parametrize("klass", [list, np.array, pd.array, pd.Series]) | ||
| def test_searchsorted_datetimelike_with_listlike(klass): |
There was a problem hiding this comment.
can you parameterize over TDI and a PeriodIndex. they should work as well
Created #32845 |
pandas/core/arrays/datetimelike.py
Outdated
| @@ -804,6 +804,9 @@ def searchsorted(self, value, side="left", sorter=None): | |||
| indices : array of ints | |||
| Array of insertion points with the same shape as `value`. | |||
| """ | |||
| if is_list_like(value): | |||
| value = array(value) | |||
Yeah, that's me confusing myself working on duplicative branches. I could try merging that one into here, hope I don't break things, and then close the other (it was originally only intended to add testing code)? |
yep one branch is fine (tests & changes) |
| if not type(self)._is_recognized_dtype(value): | ||
| raise TypeError( | ||
| "searchsorted requires compatible dtype or scalar, " | ||
| f"not {type(value).__name__}" | ||
| ) | ||
| value = type(self)(value) | ||
| self._check_compatible_with(value) | ||
|
|
||
| if not (isinstance(value, (self._scalar_type, type(self))) or (value is NaT)): |
There was a problem hiding this comment.
I get a lot of test failures if I remove this so I think it's needed
| @@ -64,6 +66,19 @@ def test_searchsorted(self, freq): | |||
| with pytest.raises(IncompatibleFrequency, match=msg): | |||
| pidx.searchsorted(Period("2014-01-01", freq="5D")) | |||
|
|
|||
| @pytest.mark.parametrize("klass", [list, np.array, array, Series]) | |||
| def test_searchsorted_different_argument_classes(self, klass): | |||
There was a problem hiding this comment.
@jbrockmendel prob should move the searchsorted tests out of here
| @@ -111,6 +112,26 @@ def test_sort_values(self): | |||
|
|
|||
| tm.assert_numpy_array_equal(dexer, np.array([0, 2, 1]), check_dtype=False) | |||
|
|
|||
| @pytest.mark.parametrize("klass", [list, np.array, array, Series]) | |||
There was a problem hiding this comment.
same ought to collect these tests
|
thanks @dsaxton I think we need to collect the index searchsorted tests and separate them out, but a separate exercise. |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff