BUG: Fix raw parameter not being respected in groupby.rolling.apply #31842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2020 22:10
|
thanks @mroeschke |
|
@mroeschke can you check if this was backported? |
|
Don't see it in https://github.com/pandas-dev/pandas/commits/1.0.x. I'll backport it when I get a chance |
|
@meeseeksdev backport to 1.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 19, 2020
…ted in groupby.rolling.apply
|
@mroeschke I mentioned it on the core list as well now, but know that often commenting with what I did above is enough, which can avoid you need to take the time to manually backport. |
jorisvandenbossche
pushed a commit
that referenced
this pull request
Feb 19, 2020
…upby.rolling.apply (#32093) Co-authored-by: Matthew Roeschke <[email protected]>
|
Thanks @jorisvandenbossche. Sorry I forgot to revisit this and backport this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raw=Trueno longer applies to groupby().rolling() in 1.0.0 #31754black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff