BUG: use entire size of DatetimeTZBlock when coercing result (#15855) #15924
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15924 +/- ##
==========================================
- Coverage 90.96% 90.96% -0.01%
==========================================
Files 145 145
Lines 49557 49557
==========================================
- Hits 45081 45079 -2
- Misses 4476 4478 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #15924 +/- ##
==========================================
+ Coverage 90.96% 90.98% +0.01%
==========================================
Files 145 145
Lines 49557 49521 -36
==========================================
- Hits 45081 45058 -23
+ Misses 4476 4463 -13
Continue to review full report at Codecov.
|
| @@ -48,3 +48,11 @@ def test_fillna_datetime64(self): | |||
| pd.Timestamp('2011-01-01 11:00', tz=tz)], | |||
| dtype=object) | |||
| self.assert_index_equal(idx.fillna('x'), exp) | |||
|
|
|||
| def test_fillna_timezone(self): | |||
There was a problem hiding this comment.
can you move to pandas/tests/frames/test_missing.py; also add a test in series/test_missing.py (if not already there).
can you also test with backfill (for both)
pandas/tests/frame/test_missing.py
Outdated
| pd.NaT]}) | ||
| exp = pd.DataFrame({'A': [pd.Timestamp('2012-11-11 00:00:00+01:00'), | ||
| pd.Timestamp('2012-11-11 00:00:00+01:00')]}) | ||
| self.assert_frame_equal(df.fillna(method='pad'), exp) |
There was a problem hiding this comment.
try to not use self. here, just assert_frame_equal (or tm.assert_frame_equal).
pandas/tests/series/test_missing.py
Outdated
| df = pd.Series([pd.Timestamp('2012-11-11 00:00:00+01:00'), pd.NaT]) | ||
| exp = pd.Series([pd.Timestamp('2012-11-11 00:00:00+01:00'), | ||
| pd.Timestamp('2012-11-11 00:00:00+01:00')]) | ||
| self.assert_series_equal(df.fillna(method='pad'), exp) |
|
thank you sir! |
git diff upstream/master --name-only -- '*.py' | flake8 --diff