DOC: fix cython example (failed on Windows) (GH6002) #11426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -274,7 +274,7 @@ advanced cython techniques: | |||
| ...: return s * dx | |||
| ...: @cython.boundscheck(False) | |||
| ...: @cython.wraparound(False) | |||
| ...: cpdef np.ndarray[double] apply_integrate_f_wrap(np.ndarray[double] col_a, np.ndarray[double] col_b, np.ndarray[Py_ssize_t] col_N): | |||
| ...: cpdef np.ndarray[double] apply_integrate_f_wrap(np.ndarray[double] col_a, np.ndarray[double] col_b, np.ndarray[int] col_N): | |||
| ...: cdef Py_ssize_t i, n = len(col_N) | |||
There was a problem hiding this comment.
prob should change all Py_ssize_t to int (next line down)
There was a problem hiding this comment.
I suppose those are not a problem, as they are only for iterating
2d87c7a to
4db0655
Compare
jorisvandenbossche
added a commit
that referenced
this pull request
Nov 1, 2015
DOC: fix cython example (failed on Windows) (GH6002)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6002
The signature of
apply_integrate_f_wrap(http://pandas-docs.github.io/pandas-docs-travis/enhancingperf.html#more-advanced-techniques) usedPy_ssize_tbut on Windows that gives an error, as the dataframe is generated with numpy random arrays, which gives int32 on Windows, whilePy_ssize_tis int64 on 64 bit Windows.