BUG, TST: Fix pandas.core.strings.str_contains when handling regex=False and case=False #7505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas.core.strings.str_contains should now match case insensitivity properly if given regex=False and case=False. Also added test cases for case insensitive pandas.core.strings.str_contains with and without regex.
|
pls add a release note in v0.14.1 (bug fix section), you can ref this PR |
|
@cpcloud @jorisvandenbossche ok by you? |
|
looking good. @benjwadams can you squash the two commits? |
|
@benjwadams thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas.core.strings.str_containsdoes not match in a case insensitive fashion at all when givenregex=Falseandcase=False. This PR should fix the situation. Additionally, there is test coverage forpandas.core.strings.str_containscase insensitive matching both with and without regular expressions enabled.