Change argument name in DataFrame.drop_duplicates

[mcobzarenco]

Just a tiny suggestion:
The keyword argument for specifying which columns to consider in drop_duplicates is called col_or_columns. Maybe change the name to col or to columns? Or the strangely long name is intended to make it clear that you can either pass in a label or a sequence of labels?

Thanks,
Marius

[wesm]

Yes, the latter case. You don't actually have to pass any columns at all, which is why it's a keyword and not a positional argument. Probably naming it col is not such a big deal

[mcobzarenco]

I know you don't need to pass in any arguments in which case it uses all
the columns.
It's only that I thought you may have called it col_or_columns such that
you remember to choose one name or the other before you commit and then
forgot :-)

Thanks,
Marius

On 2 February 2012 14:21, Wes McKinney <
reply@reply.github.com

wrote:

Yes, the latter case. You don't actually have to pass any columns at all,
which is why it's a keyword and not a positional argument. Probably naming
it col is not such a big deal

---

Reply to this email directly or view it on GitHub:
https://github.com/wesm/pandas/issues/734#issuecomment-3778575

[wesm]

ok, I changed it to cols, consistent with pivot_table and other places

[mcobzarenco]

Cool!

On 5 February 2012 00:55, Wes McKinney
reply@reply.github.com
wrote:

ok, I changed it to cols, consistent with pivot_table and other places

---

Reply to this email directly or view it on GitHub:
https://github.com/wesm/pandas/issues/734#issuecomment-3814715