Skip to content

BUG: map method on datetimelikes should not work arraywise #51979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 17, 2023
Merged

BUG: map method on datetimelikes should not work arraywise #51979

merged 4 commits into from
Mar 17, 2023

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 changed the title BUG: map method on datetimelikes sometimes work arraywise BUG: map method on datetimelikes should not work arraywise Mar 15, 2023
mroeschke
mroeschke approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be framed as an API change, but I am okay with calling this a bug especially since dicts/Series map elements.

@mroeschke mroeschke added this to the 2.1 milestone Mar 17, 2023
@mroeschke mroeschke added Bug Datetime Datetime data dtype labels Mar 17, 2023
@mroeschke mroeschke merged commit 9289f5d into pandas-dev:main Mar 17, 2023
@mroeschke
Copy link
Member

Thanks @topper-123

@topper-123 topper-123 deleted the Datetimelikes.map_elementwise branch March 17, 2023 18:04
@topper-123
Copy link
Contributor Author

Could be framed as an API change, but I am okay with calling this a bug especially since dicts/Series map elements.

Thanks. I was on the fencer too, but think I would feel it was a bug if this didn't work elementwise + the code is so much cleaner now:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Bug Datetime Datetime data dtype
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

BUG: map method on Datetimearray, TimedeltaArray, PeriodArray and related indexes should not work arraywise
2 participants
@topper-123 @mroeschke