BUG: PeriodDtype constructor allowing invalid construction, incorrect exception class #51790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Mar 5, 2023
| """ | ||
| if isinstance(freq, PeriodDtype): | ||
| return freq | ||
|
|
||
| elif freq is None: | ||
| # empty constructor for pickle compat |
There was a problem hiding this comment.
Do you know if this comment is still relevant?
There was a problem hiding this comment.
my assumption is that since it isn't in the test suite it should be OK
There was a problem hiding this comment.
Looks like this may break pre-0.19 pickle compat but that's fine IMO 6fa2b03
mroeschke
approved these changes
Mar 6, 2023
mroeschke
approved these changes
Mar 6, 2023
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.