Skip to content

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jbrockmendel jbrockmendel added API - Consistency Internal Consistency of API/Behavior Astype labels Nov 14, 2022
@mroeschke mroeschke added this to the 2.0 milestone Nov 16, 2022
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a merge conflict

@jbrockmendel
Copy link
Member Author

rebased + green

@mroeschke mroeschke merged commit 96b5780 into pandas-dev:main Nov 17, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the api-astype-floats branch November 17, 2022 15:52
MarcoGorelli pushed a commit to MarcoGorelli/pandas that referenced this pull request Nov 18, 2022
* API: Float64Index.astype(datetimelike)

* GH ref
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
* API: Float64Index.astype(datetimelike)

* GH ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API - Consistency Internal Consistency of API/Behavior Astype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants