CLN: Use cython algo for groupby var with ddof != 1 #48152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 19, 2022
|
We've got the numba tests that are testing consistency between numba and cython, so I think we are good. They are testing ddof 0 |
mroeschke
approved these changes
Aug 19, 2022
rhshadrach
requested changes
Aug 19, 2022
pandas/core/groupby/groupby.py
Outdated
| alt=lambda x: Series(x).var(ddof=ddof), | ||
| numeric_only=numeric_only, | ||
| ignore_failures=numeric_only is lib.no_default, | ||
| **{"ddof": ddof}, |
There was a problem hiding this comment.
Good point, also added whatsnew
|
Thanks @phofl |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* CLN: Use cython algo for groupby var with ddof != 1 * Adress review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @rhshadrach
I think you've implemented ddof on the cython level a while back. Any reasons why var is taking a different path? Results look sensible and no failing tests
Also, gives a nice speedup