DEPR: **kwargs in ExcelWriter #40430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Mar 14, 2021
| @@ -835,7 +862,8 @@ def __init__( | |||
| datetime_format=None, | |||
| mode: str = "w", | |||
| storage_options: StorageOptions = None, | |||
| **engine_kwargs, | |||
| engine_kwargs: Optional[Dict] = None, | |||
| **kwargs, | |||
| ): | ||
| if kwargs: | ||
| if engine_kwargs is not None: | ||
| raise ValueError("Cannot use both engine_kwargs and **kwargs") |
There was a problem hiding this comment.
can you add a test for this
…cel_engine_kwargs � Conflicts: � doc/source/whatsnew/v1.3.0.rst
|
Thanks @jreback - changes made and green. I might not have understood your comment about setting |
jreback
approved these changes
Mar 17, 2021
|
thanks @rhshadrach |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ExcelWriter has **engine_kwargs to pass through to the engine, although this is undocumented. All other places in pandas where engine_kwargs is used, they are a regular argument.
This PR