BUG: loc.setitem with expansion expanding rows #37932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 18, 2020
jreback
reviewed
Nov 18, 2020
pandas/tests/indexing/test_loc.py
Outdated
| @@ -953,6 +953,13 @@ def test_loc_setitem_empty_append(self): | |||
| df.loc[:, "x"] = data | |||
| tm.assert_frame_equal(df, expected) | |||
|
|
|||
| # same thing, but with mixed dtypes | |||
8 tasks
|
I think only #37749, but will have a closer look. At least nothing which is not already opened |
|
is this a user facing change? (if so pls add a whatsnew), also merge master and ping on green. |
jreback
approved these changes
Nov 26, 2020
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffdiscovered on branch that has dataframe always go through split_path