BUG: obj.loc[listlike] with missing keys and CategoricalIndex #37901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f-validate_read_indexer
…f-validate_read_indexer
jreback
requested changes
Nov 17, 2020
| @@ -261,10 +263,14 @@ def test_loc_listlike(self): | |||
| expected = self.df.iloc[[4, 0, 1, 5]] | |||
| tm.assert_frame_equal(result, expected, check_index_type=True) | |||
|
|
|||
There was a problem hiding this comment.
can you split the errors conditions to a separate test
There was a problem hiding this comment.
good idea, will update
…f-validate_read_indexer
jreback
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis behavior was deprecated for all other Index subclasses a few years ago and finally removed in 1.0. AFAICT not removing it for CategoricalIndex was an oversight. xref 8ab6185#r44233424