ENH Avoid redundant CSS in Styler.render #30876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where multiple cells have the same CSS, only make one CSS declaration.
| @@ -14,7 +14,7 @@ | |||
| {% block before_cellstyle %}{% endblock before_cellstyle %} | |||
| {% block cellstyle %} | |||
| {%- for s in cellstyle %} | |||
| #T_{{uuid}}{{s.selector}} { | |||
| {%- for selector in s.selectors -%}{%- if not loop.first -%},{%- endif -%}#T_{{uuid}}{{selector}}{%- endfor -%} { | |||
There was a problem hiding this comment.
It's been a while since I've looked at this, but I'm a bit confused. What is this section doing? Is it writing the css styles? Does it matter what order the selector vs the id #T_uuid goes in?
There was a problem hiding this comment.
This is just a comma-separated list of id selectors. Comma is "or", the order doesn't matter.
|
Any interest in this? |
|
this seems ok to me, basically writing the 'same' style, but de-duplicated so its much smaller? @TomAugspurger |
TomAugspurger
approved these changes
Jan 20, 2020
|
basically writing the 'same' style, but de-duplicated so its much smaller?
Yes
|
|
thanks @jnothman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where multiple styled cells have the same CSS, only make one CSS declaration. This can reduce the output size substantially.
closes #xxxxblack pandasgit diff upstream/master -u -- "*.py" | flake8 --diff