Silently ignored kwargs in Index.to_series

[jbrockmendel]

>>> idx = pd.date_range('1994-10-06', freq='D', periods=4)
>>> idx.day.to_series(index=idx)
>>> idx.day.to_series(index=idx)
6    6
7    7
8    8
9    9

Expected:

>>> idx.day.to_series(index=idx)
1994-10-06    6
1994-10-07    7
1994-10-08    8
1994-10-09    9

Looks like Index.to_series takes **kwargs but then ignores them. Should be an easy fix; would be nice to systematically track down other places this might happen.

[jreback]

yeah looks like old/typo. should be removable.

[alysivji]

I'm looking into this issue.

Fixed the Index.to_series(**kwargs) bug and added tests to common.py which also contains the original test for this method.

None of the tests in this module are being run:

$ pytest pandas/tests/indexes/common.py
================================= test session starts ==================================
platform darwin -- Python 3.6.1, pytest-3.1.2, py-1.4.34, pluggy-0.4.0
rootdir: /Users/alysivji/Documents/siv-dev/projects/open-source/pandas, inifile: setup.cfg
plugins: xdist-1.17.1
collected 0 items

============================= no tests ran in 0.01 seconds =============================

Where should I be writing my tests?

Note: same bug is also showing up in Index.to_frame(), where index=True is a default kwarg.

>>> import pandas as pd
>>> idx = pd.date_range('1994-10-06', freq='D', periods=4)
>>> idx.day.to_frame()
   0
6  6
7  7
8  8
9  9

[jreback]

common is included in all the subclasses

you can add them there