ERR: Raise ImportError when xlrd is not present #17613
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
reviewed
Sep 21, 2017
doc/source/whatsnew/v0.21.0.txt
Outdated
| @@ -115,6 +115,7 @@ Other Enhancements | |||
| - :func:`DataFrame.items` and :func:`Series.items` is now present in both Python 2 and 3 and is lazy in all cases (:issue:`13918`, :issue:`17213`) | |||
| - :func:`Styler.where` has been implemented. It is as a convenience for :func:`Styler.applymap` and enables simple DataFrame styling on the Jupyter notebook (:issue:`17474`). | |||
| - :func:`MultiIndex.is_monotonic_decreasing` has been implemented. Previously returned ``False`` in all cases. (:issue:`16554`) | |||
| - :func:`read_excel` raises ``ImportError`` with better message if ``xlrd`` is not installed | |||
gfyoung
reviewed
Sep 21, 2017
pandas/io/excel.py
Outdated
| raise ImportError("pandas requires xlrd >= 0.9.0 for excel " | ||
| "support, current version " + xlrd.__VERSION__) | ||
| err_msg = "Install xlrd >= 0.9.0 for Excel support" | ||
| try: |
gfyoung
approved these changes
Sep 21, 2017
Codecov Report
@@ Coverage Diff @@
## master #17613 +/- ##
==========================================
- Coverage 91.19% 91.17% -0.03%
==========================================
Files 163 163
Lines 49625 49629 +4
==========================================
- Hits 45257 45250 -7
- Misses 4368 4379 +11
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17613 +/- ##
==========================================
- Coverage 91.19% 91.17% -0.03%
==========================================
Files 163 163
Lines 49625 49629 +4
==========================================
- Hits 45257 45250 -7
- Misses 4368 4379 +11
Continue to review full report at Codecov.
|
alanbato
pushed a commit
to alanbato/pandas
that referenced
this pull request
Nov 10, 2017
Related issues: pandas-dev#8515, pandas-dev#14673 Author: Guilherme Beltramini <[email protected]> Closes pandas-dev#17613 from gcbeltramini/xlrd-import and squashes the following commits: dee1998 [Guilherme Beltramini] Add PR number and blank line c2759cb [Guilherme Beltramini] Throw ImportError
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
Related issues: pandas-dev#8515, pandas-dev#14673 Author: Guilherme Beltramini <[email protected]> Closes pandas-dev#17613 from gcbeltramini/xlrd-import and squashes the following commits: dee1998 [Guilherme Beltramini] Add PR number and blank line c2759cb [Guilherme Beltramini] Throw ImportError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff